Open source

[thisismydesign]

• rename
  • @nkapolcs @gomorizsolt any naming proposals? :)
• look for and remove personal settings/config
• provide actual working config example in readme
  • we could use our own data for extra exposure. @nkapolcs @gomorizsolt are you ok with having your GH/GL user names in the readme?

Prerequisites: #91, #102

[nkapolcs]

rename

My first idea was theam or theame (like team theme) :)

look for and remove personal settings/config

I don't see anything sensitive in the repo.

we could use our own data for extra exposure. @nkapolcs @gomorizsolt are you ok with having your GH/GL user names in the readme?

Of course.

[gomorizsolt]

@nkapolcs @gomorizsolt any naming proposals? :)

No proposals from my side right now.

look for and remove personal settings/config

LGTM!

@nkapolcs @gomorizsolt are you ok with having your GH/GL user names in the readme?

Sure, it's fine. 👍

[gomorizsolt]

Created #101 and #102, not sure if any of them would be critical before open-sourcing the repo.

[thisismydesign]

I was thinking about dotdev for name. I like theam but perhaps it's more difficult to explain as it's hard t figure out from the pronunciation how it's written.

[gomorizsolt]

+1 for both from my side. :)

[nkapolcs]

I like dotdev too. :)

[thisismydesign]

Renamed to dotdev.

[gomorizsolt]

Shouldn't we swap the icons with something more generic? They currently default to our logo.

• https://github.com/c-hive/dotdev/blob/e1fd40f11bbdad8f8bb44a5ecb06b170236108a3/public/favicon.ico
• https://github.com/c-hive/dotdev/tree/e1fd40f11bbdad8f8bb44a5ecb06b170236108a3/public/static/logo

I'd also change the default cover image:

• https://github.com/c-hive/dotdev/blob/e1fd40f11bbdad8f8bb44a5ecb06b170236108a3/public/static/images/cover.jpg

[thisismydesign]

Good point, could you change the default logo to a Next.js logo? We should not have that default cover image in the repo. Please remove it. If it's mandatory for the tiles, let's make the param mandatory but I'd prefer it being optional is possible.

[gomorizsolt]

If it's mandatory for the tiles, let's make the param mandatory but I'd prefer it being optional is possible.

It's optional.

dotdev/src/components/Products/Product/Product.js

Line 34 in e1fd40f

{cover && <CardMedia image={cover} title={name} />}

[thisismydesign]

Thanks, please make sure though that the tiles are not broken without a picture.

[gomorizsolt]

One thing I've noticed is that the GitHub API complains about the missing CORS policy header:

Both in production and in development.

[thisismydesign]

What feature is this breaking? Please create an issue, I assume we need to use the proxy here as well.

[gomorizsolt]

Nevermind, this seems to be working right now.

[thisismydesign]

Anything still missing to open source?

[gomorizsolt]

It's fine as-is from my side. :)

We can open-source the project and continue working on the active PRs meanwhile.

[gomorizsolt]

How about #101? The proxy server is a required config but it seems we don't make sure of it.

[gomorizsolt]

Alright, I think we're ready to make the project open-source. :)

Going forward we can refactor the code where it's required but imo it's fine as-is right now.

[thisismydesign]

Done