Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The name of the ConfigMap for the kube-downscaler is not possible to control via the configMapName key in the Helm values.yaml file #55

Closed
larssb opened this issue May 22, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@larssb
Copy link

larssb commented May 22, 2024

Issue

The kube-downscaler helm chart provides the configMapName key. One gets the impression that, with this key, I can control what the name of the generated ConfigMap that Kube-downscaler uses for uptime, downtime configuration and so forth will be named.

But, the actual name of the ConfigMap will still be py-kube-downscaler. But, the ConfigMap ref in the kube-downscaler Deployment is referring to the name one uses on the configMapName key.

See this search on this GitHub repo: https://github.com/search?q=repo%3Acaas-team%2Fpy-kube-downscaler+configMapName&type=code

And then the actual Helm template for the ConfigMap: https://github.com/caas-team/py-kube-downscaler/blob/v24.5.2/chart/templates/configmap.yaml#L4


Problem to solve

Make the a value configured on the configMapName key reflect through in all the places relevant to the ConfigMap that the kube-downscaler uses.

Further details

I did upgrade to v24.5.2.


Thank you very much.

@Fovty
Copy link
Member

Fovty commented May 23, 2024

Please give me feedback on whether the issue has been completely resolved.

@larssb
Copy link
Author

larssb commented May 28, 2024

Yes I sure will. Sorry. Been busy. I'll try to see to this ASAP.

@larssb
Copy link
Author

larssb commented Jun 5, 2024

Sorry for the delayed answer. I was finally able to get some time to test this. Yes I see what the code should work. However, because there was no new release of the Helm Chart itself, one does still get the release data/code from 5508b19 also v0.2.1 of the kube-downscaler Helm Chart.

I did try to delete all my local Helm Cache. No luck.

So can we get a 0.2.2 please 🙏

@Fovty Fovty mentioned this issue Jun 6, 2024
1 task
@Fovty
Copy link
Member

Fovty commented Jun 6, 2024

Sure, I will release a new version asap.

@Fovty Fovty closed this as completed Aug 2, 2024
@JTaeuber JTaeuber added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants