Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/remove plugins on caddy upgrade? #4213

Closed
excid3 opened this issue Jun 17, 2021 · 9 comments
Closed

Add/remove plugins on caddy upgrade? #4213

excid3 opened this issue Jun 17, 2021 · 9 comments
Labels
feature ⚙️ New feature or request good first issue 🐤 Good for newcomers
Milestone

Comments

@excid3
Copy link

excid3 commented Jun 17, 2021

I'm managing a bunch of servers and they're running Caddy v2. The upgrade command works great for upgrading with the packages previously chosen. In the future, it's likely I'll want to add/remove packages from that list over time.

Would it make sense to add flags to add and remove packages from the caddy build on upgrade?

caddy upgrade --add-package github.com/caddy-dns/cloudflare
caddy upgrade --remove-package github.com/caddy-dns/cloudflare
@excid3 excid3 changed the title Add/remove plugins on caddy upgrade Add/remove plugins on caddy upgrade? Jun 17, 2021
@mholt mholt added feature ⚙️ New feature or request good first issue 🐤 Good for newcomers help wanted 🆘 Extra attention is needed labels Jun 17, 2021
@mholt mholt added this to the 2.x milestone Jun 17, 2021
@mholt
Copy link
Member

mholt commented Jun 17, 2021

Yeah, this is something I had also thought about: #3972 (comment)

I suppose we could extend this to add and remove plugins too:
--add <package> / --remove <package>

Or maybe that should be a separate subcommand:
caddy add-package <package> / caddy remove-package <package>

Or even just:
caddy add <package> / caddy remove <package>

Not a high priority for me to work on personally, but pull requests would certainly be welcomed.

@calebikhuohon
Copy link

Hi @mholt, I'm interested in taking this up

@francislavoie
Copy link
Member

@calebikhuohon go for it!

@mholt
Copy link
Member

mholt commented Jun 20, 2021

Yeah, that'd be great. I'm still not sure which CLI approach is the best -- so just be aware I might change my mind in reviews.

@musinit
Copy link
Contributor

musinit commented Jun 26, 2021

@calebikhuohon are you working on it?) I also want to try this out

@musinit
Copy link
Contributor

musinit commented Jun 29, 2021

Guys, I am totally new in that project, but I tried to add some adding-package, if you tell me that it's absolute wrong I will remove it as quick as possible😄
#4226

@calebikhuohon
Copy link

@calebikhuohon are you working on it?) I also want to try this out

Sure 👍 Go for it

@mholt mholt closed this as completed Aug 11, 2021
@mholt
Copy link
Member

mholt commented Aug 11, 2021

All done, thanks very much @musinit!

@mholt mholt removed the help wanted 🆘 Extra attention is needed label Aug 11, 2021
@excid3
Copy link
Author

excid3 commented Aug 12, 2021

Awesome work @musinit 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request good first issue 🐤 Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants