Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags parsing is still too aggressive #1224

Closed
therealgilles opened this issue Mar 9, 2023 · 2 comments · Fixed by #1231
Closed

Tags parsing is still too aggressive #1224

therealgilles opened this issue Mar 9, 2023 · 2 comments · Fixed by #1231
Labels
bug report 🦗 Issue is probably a bug, but it needs to be checked needs: complete repro 🖥️ Issue need to have complete repro provided

Comments

@therealgilles
Copy link

therealgilles commented Mar 9, 2023

See: #1214 (comment)

This case is still not fixed:

import { styled } from '@linaria/react';

export type StyledReturn = ReturnType<typeof styled>;

results in:

SyntaxError: /home/projects/node-hyqpx9/code/exampleA.ts: /home/projects/node-hyqpx9/code/exampleA.ts: Invalid usage of `styled` tag
  1 | import { styled } from '@linaria/react';
  2 |
> 3 | export type StyledReturn = ReturnType<typeof styled>;
    |     

Reproducible Demo

Same as previous issue: stackblitz.com/edit/node-hyqpx9

@therealgilles therealgilles added bug report 🦗 Issue is probably a bug, but it needs to be checked needs: complete repro 🖥️ Issue need to have complete repro provided needs: triage 🏷 Issue needs to be checked and prioritized labels Mar 9, 2023
@github-actions github-actions bot added needs: triage 🏷 Issue needs to be checked and prioritized and removed needs: triage 🏷 Issue needs to be checked and prioritized labels Mar 9, 2023
@therealgilles
Copy link
Author

therealgilles commented Mar 9, 2023

@Anber Any chance you could take a look at this soon-ish? is there a possible workaround to disable the validateParams()?

@Anber
Copy link
Collaborator

Anber commented Apr 24, 2023

Hi @therealgilles!

Sorry for the delay :( The problem is fixed in #1239. The fix will be released with the next version in a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report 🦗 Issue is probably a bug, but it needs to be checked needs: complete repro 🖥️ Issue need to have complete repro provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants