-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use async act in render (and all other helpers really) #222
Comments
We need some compat layer – checking whether react is at certain version or so |
in the last two days, React Native updated to |
A PR to support both regular and async act would be great! |
I'm working on a RN 0.59 project; updating 0.6X is a big change and we're tackling it one step at a time. I'm really happy to see wanting to support both for now has been on your mind 👍 Having a more gradual upgrade path is really helping us out. |
I would join other guys about implementation of both variants. |
Any updates on this? |
Using async act won't magically fix your problems, because rendering is sync anyway and we won't |
Describe the Feature
Since React and
react-test-renderer
16.9.0 we have async act. This would be super helpful in the tests to remove all the act warnings and make a few tests pass that are failing otherwisePossible Implementations
The easiest option would just be to update
react-test-renderer
and then making all act calls async by default. However, I'm not sure how that would work with downwards compatibility...Related Issues
Would fix #176 and #200 which are both results of async act not being available
The text was updated successfully, but these errors were encountered: