Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add note about baseElement removed from render #533

Merged
merged 2 commits into from
Sep 3, 2020
Merged

fix: add note about baseElement removed from render #533

merged 2 commits into from
Sep 3, 2020

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Sep 3, 2020

Summary

Fixes #513 by mentioning removal of baseElement in the migration guide. We could add it to the library, but there's little to no push on that feature. Happy to introduce it later, if requested.

Test plan

None

Swor71
Swor71 reviewed Sep 3, 2020
View reviewed changes
Copy link
Member

@Swor71 Swor71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • typo in because
  • I would also change although we advise not doing so. to although we advise against doing so. as it sounds more natural. (just an opinion, tho)

@thymikee
Copy link
Member Author

thymikee commented Sep 3, 2020

@Swor71 thanks!

@thymikee thymikee merged commit e0359c6 into master Sep 3, 2020
@thymikee thymikee deleted the fix/migration-baseelement branch September 3, 2020 12:31
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swor71 Swor71 Swor71 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

baseElement is missing in v7
2 participants
@thymikee @Swor71