feat: RegExp support for *ByTestId queries #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
requested changes
Sep 7, 2020
src/helpers/getByAPI.js
Outdated
| ? testID === node.props.testID | ||
| : testID.test(node.props.testID); | ||
| } catch (error) { | ||
| throw createLibraryNotSupportedError(error); |
There was a problem hiding this comment.
We only use createLibraryNotSupportedError when importing something from react-native. No need for this try/catch here
There was a problem hiding this comment.
oh, fair enough. Sorted
thymikee
changed the title
ha, you got me while I was updating the other *ByTestId and the docs |
thymikee
reviewed
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
All *AllByTestId queries support a RegExp matcher.
We are currently preparing to migrate to the the v7 of the testing library. In our tests, the lack of this feature is a massive disadvantage for our migration as we relay in this functionality quite often.
Test plan
Tests added following preexisting tests.