Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📚 fix typo in README.md #657

Merged
merged 1 commit into from
Jan 25, 2021
Merged

📚 fix typo in README.md #657

merged 1 commit into from
Jan 25, 2021

Conversation

AbdellahRsmouki
Copy link
Contributor

Summary

The jest.config file extention should be ".json" instead of ".js"

Test plan

@AbdellahRsmouki
📚 fix typo in README.md
2a68263 
The jest.config file extention should be ".json" instead of  ".js"
thymikee
thymikee approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both js and json are correct, but since we're using json syntax, this is fine. Thanks!

@thymikee thymikee merged commit f81ebc3 into callstack:master Jan 25, 2021
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdellahRsmouki @thymikee