Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit on Home page #277

Open
LamiaSalah opened this issue Jan 29, 2019 · 16 comments
Open

Edit on Home page #277

LamiaSalah opened this issue Jan 29, 2019 · 16 comments
Assignees

Comments

@LamiaSalah
Copy link
Collaborator

@mohamedMahdyCc we need to change the text under Why Skills Builder Pro to the below?

“At BSDC we focus on three key areas of development for our learners: technical skills, soft skills (through the BSDC Skills Promise) and being an effective contributor to the local community. The addition of Skills Builder Pro soft skills library to the BSDC offer enhances this focus and gives our learners access to a suite of materials and tools that will enhance their future employability.”

Dawn Ward CBE, CEO and Principal, Burton and South Derbyshire College_

Can you also add the attached logo at the bottom right of the section?
logo

@mohamedMahdyCc
Copy link
Collaborator

mohamedMahdyCc commented Jan 30, 2019

@LamiaSalah @Ali-Galal

this enhancement will take about 0.5hr, waiting for approve

@Ali-Galal
Copy link
Collaborator

approved

@mohamedMahdyCc
Copy link
Collaborator

@LamiaSalah @ahmedelbougha @Ali-Galal @HeshamHassan
Done! please confirm and close

@LamiaSalah
Copy link
Collaborator Author

@mohamedMahdyCc please make the following edits:

  • the paragraph should have '' at the beginning and end.
  • Add the last line of the paragraph I added above as this is the speaker's name
  • The photo should be at the right as i requested
  • Please remove the frame around The logo and make the background transparent on the gray area directly.
    We need this at the soonest please

@LamiaSalah
Copy link
Collaborator Author

@mohamedMahdyCc please change the title in the Arabic toلماذا سكيلز بيلدر برو؟

@LamiaSalah
Copy link
Collaborator Author

I'll send you the logo without the background shortly

@LamiaSalah
Copy link
Collaborator Author

logo
Please align the title of the paragraph to the left side to match with the paragraph

@mohamedMahdyCc
Copy link
Collaborator

@LamiaSalah @ahmedelbougha @Ali-Galal @HeshamHassan
Done! please confirm and close

@LamiaSalah
Copy link
Collaborator Author

@mohamedMahdyCc thanks for making the edits. One final thing, in both English and Arabic the text is added in extremely close to the margin of the page, please move it inside a little bit and make the title aligned with the text underneath. with moving the logo backward as well.

@Mahmoud-Ibrahim1
Copy link

@LamiaSalah @mohamedMahdyCc Done! please confirm and close

@LamiaSalah
Copy link
Collaborator Author

@Mahmoud-Ibrahim1 why did you move the logo below the text? please keep it in its original position, next to the text and not below it.

@MoatazAbdAlmageed
Copy link

@LamiaSalah pushed I will notify you after deploy to the server.

@MoatazAbdAlmageed
Copy link

@LamiaSalah Please check

@LamiaSalah
Copy link
Collaborator Author

@MoatazAbdAlmageed it's still the same

@LamiaSalah
Copy link
Collaborator Author

LamiaSalah commented Feb 17, 2019

@MoatazAbdAlmageed could you please edit this at the soonest?

  • Also please note that the tabs at the header section for ' Find out more' are not working for the 1st and 4th photo.

  • For the second section in the page with 4 tabs,, the ''Partner with SBP'' and ''Customize your Training'' links are not working.

@MoatazAbdAlmageed
Copy link

I pushed it I will notify you after deploy.

Note: please use use gitlab instead of github
https://gitlab.com/camelcasetech/skillsbuilderpro/issues/28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants