diff --git a/pom.xml b/pom.xml index 5d9f3a08..67c4369c 100644 --- a/pom.xml +++ b/pom.xml @@ -4,7 +4,7 @@ io.zeebe zeebe-simple-monitor - 2.5.3-2-SNAPSHOT + 2.6.2-SNAPSHOT jar @@ -19,7 +19,7 @@ UTF-8 8.3.4 - 8.3.4.3 + 8.3.4.5 1.4.0 5.0.0 diff --git a/src/main/java/io/zeebe/monitor/repository/VariableRepository.java b/src/main/java/io/zeebe/monitor/repository/VariableRepository.java index f13c9478..4cfbcb1a 100644 --- a/src/main/java/io/zeebe/monitor/repository/VariableRepository.java +++ b/src/main/java/io/zeebe/monitor/repository/VariableRepository.java @@ -16,14 +16,13 @@ package io.zeebe.monitor.repository; import io.zeebe.monitor.entity.VariableEntity; -import org.springframework.data.domain.Page; -import org.springframework.data.domain.Pageable; import org.springframework.data.repository.CrudRepository; -import org.springframework.data.repository.PagingAndSortingRepository; -public interface VariableRepository extends PagingAndSortingRepository, CrudRepository { +import java.util.List; - Page findByProcessInstanceKey(long processInstanceKey, Pageable pageable); +public interface VariableRepository extends CrudRepository { + + List findByProcessInstanceKeyOrderByTimestampAscIdAsc(long processInstanceKey); long countByProcessInstanceKey(long processInstanceKey); } diff --git a/src/main/java/io/zeebe/monitor/rest/InstancesVariableListController.java b/src/main/java/io/zeebe/monitor/rest/InstancesVariableListController.java index 994976e5..4916345d 100644 --- a/src/main/java/io/zeebe/monitor/rest/InstancesVariableListController.java +++ b/src/main/java/io/zeebe/monitor/rest/InstancesVariableListController.java @@ -55,7 +55,7 @@ protected void fillViewDetailsIntoDto( Pageable pageable, ProcessInstanceDto dto) { final Map> variablesByScopeAndName = - variableRepository.findByProcessInstanceKey(instance.getKey(), pageable).stream() + variableRepository.findByProcessInstanceKeyOrderByTimestampAscIdAsc(instance.getKey()).stream() .collect(Collectors.groupingBy(v -> new VariableTuple(v.getScopeKey(), v.getName()))); variablesByScopeAndName.forEach( (scopeKeyName, variables) -> { @@ -87,7 +87,7 @@ protected void fillViewDetailsIntoDto( }); final long count = variableRepository.countByProcessInstanceKey(instance.getKey()); - addPaginationToModel(model, pageable, count); + addPaginationToModel(model, Pageable.ofSize(Integer.MAX_VALUE), count); } private static class VariableTuple { diff --git a/src/test/java/io/zeebe/monitor/rest/InstancesVariableListControllerTest.java b/src/test/java/io/zeebe/monitor/rest/InstancesVariableListControllerTest.java index a7ffd086..f39551d5 100644 --- a/src/test/java/io/zeebe/monitor/rest/InstancesVariableListControllerTest.java +++ b/src/test/java/io/zeebe/monitor/rest/InstancesVariableListControllerTest.java @@ -11,6 +11,8 @@ import io.zeebe.monitor.entity.ProcessEntity; import io.zeebe.monitor.entity.ProcessInstanceEntity; + +import java.util.Collections; import java.util.Optional; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; @@ -24,8 +26,8 @@ public class InstancesVariableListControllerTest extends AbstractViewOrResourceT public void setUp() { when(processRepository.findAll(any(Pageable.class))).thenReturn(Page.empty()); when(elementInstanceRepository.findByProcessInstanceKey(anyLong())).thenReturn(Page.empty()); - when(variableRepository.findByProcessInstanceKey(anyLong(), any(Pageable.class))) - .thenReturn(Page.empty()); + when(variableRepository.findByProcessInstanceKeyOrderByTimestampAscIdAsc(anyLong())) + .thenReturn(Collections.emptyList()); } @Test