Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv plugin fails if _get_system_python_interpreter returns None #991

Open
bepri opened this issue Jan 24, 2025 · 1 comment · May be fixed by #1003
Open

uv plugin fails if _get_system_python_interpreter returns None #991

bepri opened this issue Jan 24, 2025 · 1 comment · May be fixed by #1003
Assignees
Labels
Bug Something isn't working Triaged

Comments

@bepri
Copy link
Contributor

bepri commented Jan 24, 2025

Bug Description

In the base abstract definition of _get_system_python_interpreter() below, it is possible to return None.

def _get_system_python_interpreter(self) -> str | None:

However, this line below attempts to stringify the return value of _get_system_python_interpreter(), which will always break if set to None.

f'uv venv --relocatable --allow-existing --python "{self._get_system_python_interpreter()}" "{self._get_venv_directory()}"',

To Reproduce

Override UvPlugin's _get_system_python_interpreter to return None, then attempt to build a project.

part yaml

Relevant log output

N/A
@bepri bepri added the Bug Something isn't working label Jan 24, 2025
@bepri bepri self-assigned this Jan 24, 2025
@bepri bepri added the Triaged label Jan 24, 2025
Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-4010.

This message was autogenerated

@bepri bepri linked a pull request Feb 3, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant