Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context to API calls #105

Open
autocracy opened this issue Nov 26, 2024 · 2 comments
Open

feat: add context to API calls #105

autocracy opened this issue Nov 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@autocracy
Copy link

The HTTP client can be set with

c, err := gomaasclient.GetClientWithTransport(endpoint, apiToken, "2.0", otelhttp.NewTransport(http.DefaultTransport))

But because all calls take no context cancellation cannot be propagated nor things like trace context. Please add trace context to all calls that is propagated to the HTTP library

@andylshort andylshort added the enhancement New feature or request label Nov 27, 2024
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Dec 28, 2024
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
@skatsaounis skatsaounis reopened this Jan 27, 2025
@github-actions github-actions bot removed the stale label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants