Avoid race condition between graphics driver and lightdm #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
|
signed |
|
CI needs re-trigger but the change itself checks out. |
Without `logind-check-graphical=True` beeing set, lightdm is prone to a race condition, where lightdm has started before the graphics driver was loaded.
|
Looks like in 2014 this feature was unreliable. I'd hope that is no longer the case! |
|
Tests passed locally, so this should be good to land, thanks @gsilvan! |
|
It seems that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possible race condition where lightdm fails to a black screen/tty, if lightdm loads faster than the system graphics driver. There is already the setting
logind-check-graphicalbut it is unset per default.As more and more people run into this pitfail, this PR sets
logind-check-graphical=True.References
https://wiki.archlinux.org/title/LightDM#LightDM_does_not_appear_or_monitor_only_displays_TTY_output
https://www.reddit.com/r/linuxmasterrace/comments/p9ebi0/logindcheckgraphicaltrue/
https://askubuntu.com/questions/1360285/login-screen-issue-first-lightdm-needs-to-be-killed-to-get-x-session-to-work
#165