From 109e268126148afa7f10ccf45720fbc87534ff06 Mon Sep 17 00:00:00 2001 From: Steven Davidovitz Date: Thu, 17 Mar 2016 14:10:34 -0700 Subject: [PATCH 1/6] character classes or pipes, not both --- lib/sshkit/host.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sshkit/host.rb b/lib/sshkit/host.rb index cd532469..f4a1db8d 100644 --- a/lib/sshkit/host.rb +++ b/lib/sshkit/host.rb @@ -99,7 +99,7 @@ def properties class SimpleHostParser def self.suitable?(host_string) - !host_string.match(/[:|@]/) + !host_string.match(/:|@/) end def initialize(host_string) @@ -127,7 +127,7 @@ def attributes class HostWithPortParser < SimpleHostParser def self.suitable?(host_string) - !host_string.match(/[@|\[|\]]/) + !host_string.match(/@|\[|\]/) end def port From d0183403ba10a1645fc4faf89118ad86e24c5077 Mon Sep 17 00:00:00 2001 From: Steven Davidovitz Date: Thu, 17 Mar 2016 14:11:22 -0700 Subject: [PATCH 2/6] output_verbosity accessors are redefined inside the class --- lib/sshkit/configuration.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sshkit/configuration.rb b/lib/sshkit/configuration.rb index a9e8a396..333ac05f 100644 --- a/lib/sshkit/configuration.rb +++ b/lib/sshkit/configuration.rb @@ -2,7 +2,7 @@ module SSHKit class Configuration - attr_accessor :umask, :output_verbosity + attr_accessor :umask attr_writer :output, :backend, :default_env, :default_runner def output From 894b59fa0bda1c57342dd69de54d24d9a8c06aa6 Mon Sep 17 00:00:00 2001 From: Steven Davidovitz Date: Thu, 17 Mar 2016 14:12:39 -0700 Subject: [PATCH 3/6] ruby doesn't like private attr_readers --- lib/sshkit/backends/connection_pool.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/sshkit/backends/connection_pool.rb b/lib/sshkit/backends/connection_pool.rb index e1b0f0f6..3b093103 100644 --- a/lib/sshkit/backends/connection_pool.rb +++ b/lib/sshkit/backends/connection_pool.rb @@ -78,10 +78,12 @@ def close_connections end end - private + protected attr_reader :caches, :timed_out_connections + private + def cache_enabled? idle_timeout && idle_timeout > 0 end From 02b753dfb7ff363a221674658bc2beafc340a361 Mon Sep 17 00:00:00 2001 From: Steven Davidovitz Date: Thu, 17 Mar 2016 14:13:15 -0700 Subject: [PATCH 4/6] ruby doesn't like private attr_readers --- lib/sshkit/backends/connection_pool/cache.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/sshkit/backends/connection_pool/cache.rb b/lib/sshkit/backends/connection_pool/cache.rb index f29f2ba1..dbce2d39 100644 --- a/lib/sshkit/backends/connection_pool/cache.rb +++ b/lib/sshkit/backends/connection_pool/cache.rb @@ -53,10 +53,12 @@ def clear end end - private + protected attr_reader :connections, :idle_timeout, :closer + private + def fresh?(expires_at) expires_at > Time.now end From 2d4cea260bad4d4ac9b1cc0a5b2236b245937e0c Mon Sep 17 00:00:00 2001 From: Steven Davidovitz Date: Thu, 17 Mar 2016 14:13:47 -0700 Subject: [PATCH 5/6] attr_reader for SSHKit.config is written manually --- lib/sshkit.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sshkit.rb b/lib/sshkit.rb index cae4feba..b640ca3a 100644 --- a/lib/sshkit.rb +++ b/lib/sshkit.rb @@ -4,7 +4,7 @@ module SSHKit class << self - attr_accessor :config + attr_writer :config def configure @@config ||= Configuration.new From 821264c3d2b7057f58939df2436b1f875b395873 Mon Sep 17 00:00:00 2001 From: Steven Davidovitz Date: Thu, 17 Mar 2016 14:17:15 -0700 Subject: [PATCH 6/6] remove the existing default_files Silences "warning: method redefined; discarding old default_files" --- lib/sshkit/backends/netssh.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/sshkit/backends/netssh.rb b/lib/sshkit/backends/netssh.rb index c916860e..f3293046 100644 --- a/lib/sshkit/backends/netssh.rb +++ b/lib/sshkit/backends/netssh.rb @@ -5,6 +5,8 @@ module Net module SSH class Config class << self + remove_method :default_files + def default_files @@default_files + [File.join(Dir.pwd, '.ssh/config')] end