Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update downshift to the latest version ^2.0.0 #2628

Closed
alisonjoseph opened this issue Jul 13, 2018 · 6 comments · Fixed by #5373
Closed

Update downshift to the latest version ^2.0.0 #2628

alisonjoseph opened this issue Jul 13, 2018 · 6 comments · Fixed by #5373
Labels
package: react carbon-components-react status: inactive Will close if there's no further activity within a given time type: enhancement 💡

Comments

@alisonjoseph
Copy link
Member

Will need to refactor components that utilize it.

@joshblack
Copy link
Contributor

Are there any big breaking changes with this? Seems like we'd need to update our use of the render prop to children, don't see anything else off the top of my head that would need to be changed. Thoughts?

@alisonjoseph
Copy link
Member Author

I'm not super familiar with downshift, I just know when I tried running the PR that greenkeeper created some of the components were broken. Just made this issue for us to look at at some point when we had time to update things.

@stale
Copy link

stale bot commented May 2, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@carbon-bot
Copy link
Contributor

Hi there! 👋 If you're wondering why this issue was moved, we're currently updating our repo structure so that every package is found in the same project.

This should not have any impact for you, but we wanted to give you a heads up in case you were wondering what is going on. If you have any questions, feel free to reach out to us on Slack or contact us at: [email protected]. Thanks!

@stale
Copy link

stale bot commented Jun 8, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 8, 2019
@stale
Copy link

stale bot commented Jun 11, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react status: inactive Will close if there's no further activity within a given time type: enhancement 💡
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants