Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Support #3565

Closed
davidicus opened this issue Jul 29, 2019 · 5 comments
Closed

RTL Support #3565

davidicus opened this issue Jul 29, 2019 · 5 comments

Comments

@davidicus
Copy link
Contributor

Use this template if you want to request a new feature, or a change to an
existing feature.

If you are reporting a bug or problem, please use the bug template instead.

Summary

I would like the components to have RTL support. This may require both dev and design.

I would also like to have the RTL knob added to storybook so RTL design can be assessed directly from storybook.

Justification

Different languages have the opposite page orientation for text. The UI should be able to adapt to these language changes.

Desired UX and success metrics

If the UI doesn't blow up when RTL is enabled then its a win 🎉

"Must have" functionality

Components support RTL

Available extra resources

I can go through components and submit PRs as we go once RTL addon is added to storybook.

@asudoh
Copy link
Contributor

asudoh commented Jul 29, 2019

Hi 👋 would you want to start with CARBON_REACT_STORYBOOK_USE_RTL? (Ref)

Also please refer to our g11n guide, too.

@davidicus
Copy link
Contributor Author

Thanks. Will do!

@asudoh
Copy link
Contributor

asudoh commented Jul 30, 2019

OK let me close this for now - If there are any specific RTL issues feel free to enter ones!

@asudoh asudoh closed this as completed Jul 30, 2019
@davidicus
Copy link
Contributor Author

I will do. @asudoh are there any plans for the Carbon team to work on RTL support in your roadmap?

@tw15egan
Copy link
Collaborator

We've had a few issues regarding RTL from teams and resolved them, so we're assuming it is working correctly. If you encounter any specific RTL issues definitely create an issue so we can tackle it, as we'd consider it a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants