Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle text breaks to new lines #5392

Closed
1 of 2 tasks
clarebyrne opened this issue Feb 19, 2020 · 0 comments · Fixed by #5393
Closed
1 of 2 tasks

Toggle text breaks to new lines #5392

clarebyrne opened this issue Feb 19, 2020 · 0 comments · Fixed by #5393
Assignees

Comments

@clarebyrne
Copy link

clarebyrne commented Feb 19, 2020

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.
When browser is in Chinese langauge (eg Chrome: Chinese Simplified/traditional/Hong Kong) toggle text breaks to a new line for each character.

Is this issue related to a specific component?
ToggleSmall.js

What did you expect to happen? What happened instead? What would you like to
see changed?
Add 'white-space: nowrap' property to toggle__text--on/toggle__text--off, this fixes issue

What browser are you working in?
Chrome

Steps to reproduce the issue

  1. Step one
    Go to toggle small in Storybook https://react.carbondesignsystem.com/?path=/story/toggle--toggled
  2. Step two
    Change toggle text to Chinese characters, eg 已啟用

Additional information

  • Screenshots or code

Screenshot 2020-02-18 at 10 59 04

  • Notes
@tw15egan tw15egan changed the title Add w Toggle text breaks to new lines Feb 19, 2020
@tw15egan tw15egan self-assigned this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants