Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icon generation command to use source assets #5694

Closed
joshblack opened this issue Mar 24, 2020 · 0 comments · Fixed by #5711
Closed

Update icon generation command to use source assets #5694

joshblack opened this issue Mar 24, 2020 · 0 comments · Fixed by #5711

Comments

@joshblack
Copy link
Contributor

We currently use our optimized assets when generating icons in Sketch and this is causing several rendering issues, such as #4053 and #5568. This also causes some issues on website where people are downloading icons and putting them into Sketch.

As a result, we'd like to move towards using our source assets to generate Sketch symbols. This work will include:

  • Authoring an extension to our metadata package to support adding asset source information to metadata
  • Including this extension in generated assets for the plugin
  • Update the plugin command to use the source asset instead of taking the build info and generating the source from that descriptor

This work will also include:

  • Coordinating with website around the addition of this extension and working with them to see how we can expose this in the download as opposed to the current solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant