From 073db0b049ba8991492569641d9cb1b00c8d4fd2 Mon Sep 17 00:00:00 2001 From: TJ Egan Date: Wed, 22 Jan 2020 14:11:27 -0800 Subject: [PATCH 1/2] fix(datatable): add padding so search clear button doesn't obstruct text --- .../src/components/data-table/_data-table-action.scss | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/packages/components/src/components/data-table/_data-table-action.scss b/packages/components/src/components/data-table/_data-table-action.scss index 9d7746b94372..e18f63d64667 100644 --- a/packages/components/src/components/data-table/_data-table-action.scss +++ b/packages/components/src/components/data-table/_data-table-action.scss @@ -141,7 +141,7 @@ .#{$prefix}--toolbar-search-container-active .#{$prefix}--search .#{$prefix}--search-input { - padding-left: $spacing-09; + padding: 0 $spacing-09; visibility: inherit; } @@ -197,6 +197,11 @@ background-color: transparent; } + .#{$prefix}--toolbar-search-container-persistent + .#{$prefix}--search-close::before { + display: none; + } + //------------------------------------------------- //TOOLBAR BUTTONS //------------------------------------------------- @@ -296,7 +301,7 @@ .#{$prefix}--search .#{$prefix}--search-input { height: $layout-04; - padding-left: $spacing-09; + padding: 0 $spacing-09; border: none; } @@ -513,7 +518,7 @@ .#{$prefix}--toolbar-search-container-expandable .#{$prefix}--search .#{$prefix}--search-input { - padding-left: $spacing-xl; + padding: 0 $spacing-09; } //active From 8219f7b9c37274d9f618277c4b8a68c9d7f7a76e Mon Sep 17 00:00:00 2001 From: TJ Egan Date: Thu, 23 Jan 2020 13:15:42 -0800 Subject: [PATCH 2/2] fix(datatable): fix search close focus issue --- .../src/components/data-table/_data-table-action.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/components/src/components/data-table/_data-table-action.scss b/packages/components/src/components/data-table/_data-table-action.scss index e18f63d64667..baa510c927c4 100644 --- a/packages/components/src/components/data-table/_data-table-action.scss +++ b/packages/components/src/components/data-table/_data-table-action.scss @@ -123,6 +123,12 @@ } } + .#{$prefix}--toolbar-search-container-expandable + .#{$prefix}--search + .#{$prefix}--search-close:focus::before { + background-color: $focus; + } + //------------------------------------------------- //ACTIVE SEARCH - DEFAULT TOOLBAR //-------------------------------------------------