Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor agent-node and test for different event filters #286

Open
Sital999 opened this issue Dec 26, 2024 · 4 comments
Open

Refactor agent-node and test for different event filters #286

Sital999 opened this issue Dec 26, 2024 · 4 comments
Assignees

Comments

@Sital999
Copy link
Collaborator

Sital999 commented Dec 26, 2024

  • Add support for plural form of event-filter like for "output" , in case of failure add "outputs"
  • Add support for event filters containing operator despite having multiple properties
    • eg: address have multiple properties and previously only its properties were used for filter. Now it is also added as filter along with all filter containing operators.
  • Add support for filters having no properties. (fee doesn't have properties so previously it was ignored)
  • Test for different filters and note down the drawbacks in transactionSchema
@Sital999 Sital999 self-assigned this Dec 26, 2024
@Sital999
Copy link
Collaborator Author

  • Add search option in CustomComboBox
  • Add object of "id" and "label" as intial item

@mesudip
Copy link
Contributor

mesudip commented Jan 2, 2025

Moved back to In progress

ToDos:

  • update the Logical Execution function to suport using fromString and compare functions by default if they are available.
  • Update UI to support exists for all of the fields.
  • Fix schema @mesudip or @reeshavacharya

@Sital999
Copy link
Collaborator Author

Sital999 commented Jan 3, 2025

As of now following has been implemented

  • Added support for Address and Value comparisions
  • Also added Logical execution function to support using fromString or fromAny for conversion and compare for comparision
  • Updated UI to support exists operator for top level filter like outputs, inputs
  • Added input fields conditionally for event filter parameters where it is hidden for exists operator.
  • Agent node was also updated to support above feature

@Sital999
Copy link
Collaborator Author

Sital999 commented Jan 6, 2025

  • Support for failed creation of proposal due to stakeUnregistered also added.
  • Fix UI in event parameter input fields to update state on deletion of parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants