Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for amd and commonjs #25

Closed
jescalan opened this issue Jan 28, 2014 · 2 comments
Closed

Build for amd and commonjs #25

jescalan opened this issue Jan 28, 2014 · 2 comments
Assignees
Labels

Comments

@jescalan
Copy link

Share button should be easily consumable through both amd and commonjs, as both are already very common ways of managing js modules, and will only become more so in the future. UMD is probably a good way to handle this.

In addition, it should be easily able to be used through node or bower, meaning we'll need a couple adjustments to the package.json and a component.json added as well. We can use browserify to run this compile much like jade does here.

@jescalan
Copy link
Author

To add some extra info here, the AMD build is the only piece that would benefit from any actual extra code, and would probably look to see if define is defined, and if so wrap in a define block that depends on jquery. The latest versions of jquery are now on npm and stable, so it might be worth considering adding jquery to the package.json as a dep, but jquery's integration with npm is very young, and I wonder if this would end up confusing people further. The bower piece should be simple -- very similar to npm, but it's built very specifically for client side: https://github.com/bower/bower#defining-a-package

@jescalan jescalan self-assigned this Feb 12, 2014
@tmilewski
Copy link
Contributor

Will close with #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants