Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only works with class names as selectors not ids #70

Closed
finnp opened this issue Mar 14, 2014 · 3 comments
Closed

Only works with class names as selectors not ids #70

finnp opened this issue Mar 14, 2014 · 3 comments
Assignees
@tmilewski
Labels
bug

Comments

@finnp
Copy link

finnp commented Mar 14, 2014

Hey,

I just noticed an annoying bug. If the element is chosen through an id like $('#share') it doesn't work as expected. Only using class names like $('.share') works.

Would look into it, when I have some time :)

Best,
Finn
@tmilewski tmilewski added the bug label Mar 14, 2014
@tmilewski
Copy link
Contributor

Thanks for the bug. Once implemented, albeit a breaking update, this will be fixed with #69.

@tmilewski tmilewski self-assigned this Mar 14, 2014
@finnp
Copy link
Author

finnp commented Mar 14, 2014

Okay, great. Seems like that's happening soon. 🎉

@tmilewski
Copy link
Contributor

Merged #69. Should fix your issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmilewski tmilewski

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmilewski @finnp