Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get_implicit_users_for_permission() #168

Merged
merged 1 commit into from
Jun 16, 2021
Merged

fix: get_implicit_users_for_permission() #168

merged 1 commit into from
Jun 16, 2021

Conversation

ffyuanda
Copy link
Member

@ffyuanda ffyuanda commented Jun 16, 2021 •
edited
Loading

Fix: #167

Signed-off-by: ffyuanda [email protected]

@ffyuanda ffyuanda mentioned this pull request Jun 16, 2021
Closed
@ffyuanda
Copy link
Member Author

@hsluoyz @Zxilly please review

@hsluoyz
Copy link
Member

hsluoyz commented Jun 16, 2021

@ffyuanda fix:

image

@hsluoyz
Copy link
Member

hsluoyz commented Jun 16, 2021

@gmc77 @Zxilly @techoner plz review.

@hsluoyz hsluoyz requested review from leeqvip and Zxilly June 16, 2021 12:37
@ffyuanda
Copy link
Member Author

@hsluoyz that could be a third-party issue, not sure how to resolve it yet

@hsluoyz
Copy link
Member

hsluoyz commented Jun 16, 2021

@ffyuanda can we fix it by updating semantic-release package version or Node.js version? (I note it's still Node.js 10 and it's very old already)

image

@hsluoyz
Copy link
Member

hsluoyz commented Jun 16, 2021

@ffyuanda we encountered the same error in jCasbin, see: semantic-release/semantic-release#1981 (comment)

See jCasbin's fix: casbin/jcasbin#203

@ffyuanda
Copy link
Member Author

@hsluoyz it seems to solve the issue nicely, thank you!

hsluoyz
hsluoyz requested changes Jun 16, 2021
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
casbin/enforcer.py Outdated Show resolved Hide resolved
leeqvip
leeqvip suggested changes Jun 16, 2021
View reviewed changes
casbin/enforcer.py Outdated Show resolved Hide resolved
@ffyuanda
fix: get_implicit_users_for_permission()
8a11f6c 
ci: upgrade node.js version

test: addded more comprehensive tests for get_implicit_users_for_permission()

Signed-off-by: ffyuanda <[email protected]>
@ffyuanda
Copy link
Member Author

@hsluoyz @techoner plz review

@ffyuanda ffyuanda requested review from hsluoyz and leeqvip June 16, 2021 14:20
@leeqvip leeqvip merged commit 92e1110 into casbin:master Jun 16, 2021
github-actions bot pushed a commit that referenced this pull request Jun 16, 2021
@semantic-release-bot
chore(release): 1.1.3 [skip ci]
c6aa890 
## [1.1.3](v1.1.2...v1.1.3) (2021-06-16)

### Bug Fixes

* get_implicit_users_for_permission() ([#168](#168)) ([92e1110](92e1110))
@hsluoyz
Copy link
Member

hsluoyz commented Jun 16, 2021

🎉 This PR is included in version 1.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hsluoyz hsluoyz mentioned this pull request Jun 17, 2021
Closed
@gmc77
Copy link

gmc77 commented Jun 17, 2021

Thanks for the quick turnaround! Had actually patched it locally and was going to raise a PR but your beat me to it (had nearly exactly the same fix).

Cheers.

@ffyuanda
Copy link
Member Author

@gmc77 No worries, glad that the issue is fixed! Didn't mean to take your work XD. Anyway, happy using PyCasbin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeqvip leeqvip leeqvip approved these changes

@Zxilly Zxilly Awaiting requested review from Zxilly

@hsluoyz hsluoyz Awaiting requested review from hsluoyz

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_implicit_users_for_permission() incorrect
4 participants
@ffyuanda @hsluoyz @gmc77 @leeqvip