Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add third-party Compose UI lints to enforce best practices #1529

Closed
JakeWharton opened this issue Sep 28, 2023 · 4 comments · Fixed by #1819
Closed

Add third-party Compose UI lints to enforce best practices #1529

JakeWharton opened this issue Sep 28, 2023 · 4 comments · Fixed by #1819
Labels
area/build and CI PR welcome

Comments

@JakeWharton
Copy link
Collaborator

We're getting enough Compose UI going.

https://slackhq.github.io/compose-lints/
@JakeWharton
Copy link
Collaborator Author

JakeWharton commented Oct 2, 2023 •
edited
Loading

Actually using Lint is a poor choice for this.

https://github.com/mrmans0n/compose-rules supports ktlint or detekt which are both superior options as they are not limited to Android code.

@JakeWharton
Copy link
Collaborator Author

Spotless doesn't allow custom ktlint rulesets, apparently. JFC this ecosystem...

@JakeWharton
Copy link
Collaborator Author

Detekt release version doesn't work with 1.9.10. The hits keep on coming.

@JakeWharton
Copy link
Collaborator Author

Should be unblocked by #1704

@JakeWharton JakeWharton mentioned this issue Feb 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build and CI PR welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Compose rules for ktlint cashapp/redwood
1 participant
@JakeWharton