Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to override the service port name #528

Open
mmastersvz opened this issue Sep 27, 2024 · 1 comment
Open

Add the ability to override the service port name #528

mmastersvz opened this issue Sep 27, 2024 · 1 comment

Comments

@mmastersvz
Copy link

Add into https://github.com/castai/helm-charts/blob/main/charts/castai-pod-node-lifecycle/templates/service.yaml#L9-L16 a variable to override the service port name.

When using istio the current port name results in IST0118. See https://istio.io/latest/docs/reference/config/analysis/ist0118/#how-to-resolve

values.yaml

  service:
    portNames:
      https: "https"
      metrics: "metrics"

service.yaml

  ports:
    - name:  {{ .Values.service.portNames.https }}
      protocol: TCP
      port: 443
      targetPort: https
    - name:  {{ .Values.service.portNames.metrics }}
      protocol: TCP
      port: 9090
      targetPort: 9090

Then can set it to override to eliminate IST0118

  service:
    portNames:
      https: "tcp-https"
      metrics: "tcp-metrics"
@mmastersvz
Copy link
Author

mmastersvz commented Dec 17, 2024

Here is the diff report if someone can create a PR
changes.TGZ

[castai-pod-node-lifecycle] add support for overriding service port names
Allows users to hand IST0118 when using Istio https://istio.io/latest/docs/reference/config/analysis/ist0118/#how-to-resolve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant