-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NuGet package has wrong dependency from the "System.ComponentModel.TypeConverter" package #239
Comments
The dependency on the non-existent 4.0.1 package causes NuGet restore to float downwards. Each restore will try again to check if 4.0.1 exists on a source since it is the best match. Restore caches the list of versions from http feeds for 30 minutes, but after that it will again make http requests to each feed looking for the package again. I'm currently hitting this due to Moq 4.7.1's dependency on Castle.Core. |
Sorry my fault. @jonorossi I will submit a PR. Do you have plan to release a new version with this fix on NuGet? |
I have upgraded this package in the work I am doing to move all the build infrastructure over the new VS2017 tooling in #241. Please see: https://github.com/fir3pho3nixx/Core/blob/master/src/Castle.Core/Castle.Core-VS2017.csproj#L26 If we go up to 4.3.0, do you think it will still be a problem? |
No, if there's no plan to release a minor update before your work is done then this fix is not necessary. |
No problem, I'm surprised nuget.org doesn't verify that dependencies actually exist.
My plan was to release a minor release with this fix after we've moved over the build process. |
Fix is in v4.1. |
See the Castle.Core.nuspec file:
The "System.ComponentModel.TypeConverter" package with the 4.0.1 version does not exist.
It seems that the "4.1.0" version should be used (like in project.json)
The text was updated successfully, but these errors were encountered: