Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package has wrong dependency from the "System.ComponentModel.TypeConverter" package #239

Closed
San4es opened this issue Mar 21, 2017 · 6 comments
Labels
Milestone

Comments

@San4es
Copy link

San4es commented Mar 21, 2017

See the Castle.Core.nuspec file:

<dependency id="System.ComponentModel.TypeConverter" version="4.0.1" />

The "System.ComponentModel.TypeConverter" package with the 4.0.1 version does not exist.

It seems that the "4.1.0" version should be used (like in project.json)

@emgarten
Copy link

The dependency on the non-existent 4.0.1 package causes NuGet restore to float downwards. Each restore will try again to check if 4.0.1 exists on a source since it is the best match.

Restore caches the list of versions from http feeds for 30 minutes, but after that it will again make http requests to each feed looking for the package again.

I'm currently hitting this due to Moq 4.7.1's dependency on Castle.Core.

@jeremymeng
Copy link
Contributor

jeremymeng commented Apr 15, 2017

Sorry my fault.

@jonorossi I will submit a PR. Do you have plan to release a new version with this fix on NuGet?

@ghost
Copy link

ghost commented Apr 15, 2017

I have upgraded this package in the work I am doing to move all the build infrastructure over the new VS2017 tooling in #241.

Please see: https://github.com/fir3pho3nixx/Core/blob/master/src/Castle.Core/Castle.Core-VS2017.csproj#L26

If we go up to 4.3.0, do you think it will still be a problem?

@jeremymeng
Copy link
Contributor

jeremymeng commented Apr 16, 2017

If we go up to 4.3.0, do you think it will still be a problem?

No, if there's no plan to release a minor update before your work is done then this fix is not necessary.

@jonorossi
Copy link
Member

Sorry my fault.

No problem, I'm surprised nuget.org doesn't verify that dependencies actually exist.

I will submit a PR. Do you have plan to release a new version with this fix on NuGet?

My plan was to release a minor release with this fix after we've moved over the build process.

@jonorossi jonorossi added this to the v4.1 milestone Jun 8, 2017
@jonorossi
Copy link
Member

Fix is in v4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants