-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't run 2CR on pre-built indexes directly on fatjar - can't read YAML files #2427
Comments
working on this |
Sorry, I was prepping for final exams and working on hackathon stuff. I am happy to help @16BitNarwhal if there is any question :) |
@16BitNarwhal any progress on this? |
I was able get RunMsMarco to read the YAML file from within the fatjar but the fatjar is still not completely self-contained as it can only be run from the root directory (it needs access to I'm having a bit of trouble proceeding from here |
I think you need to read directly from a jar, something like this? https://stackoverflow.com/questions/20389255/reading-a-resource-file-from-within-jar |
#2469 was a first step, but we have another issue:
The commands are using |
I think a solution could be to locate the fatjar in java and format the command string to use the located path i.e. This way, running shouldn't depend on any files in the repo like |
Yea, I tried that... I was playing with something like
And then it got too janky. I'm thinking a reasonable solution might be to just store the sh scripts in the fatjar, and just extract the scripts into
This is doable also, but you just need to define the variable first... which isn't too bad, but just one more thing to do... |
BTW, we need to both run in the repo (i.e., cloned copy) and also in an arbitrary location... so by the time you get this working, it'll end up looking pretty janky also. |
I was thinking something along the lines of this I think this can reliably find the fatjar file for any location |
Want to give it a try? |
Yes! |
I replaced both I think RunMsMarco still depends on |
Closed by #2476. |
We need to read the YAML files from the fatjar, not depend on a local file:
The text was updated successfully, but these errors were encountered: