Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST API design #2481

Closed
lintool opened this issue Apr 30, 2024 · 4 comments
Closed

REST API design #2481

lintool opened this issue Apr 30, 2024 · 4 comments
Assignees

Comments

@lintool
Copy link
Member

lintool commented Apr 30, 2024

@16BitNarwhal will work on this.

A few resources:

@16BitNarwhal will propose a few designs... @sahel-sh and @ronakice and I will provide feedback.

See castorini/rank_llm#110 for what I mean by "propose a few designs".

@lintool
Copy link
Member Author

lintool commented Apr 30, 2024

Another thing to consider: what does Elasticsearch and OpenSearch expose? One option is just to mirror that?

@16BitNarwhal
Copy link
Member

I'm currently thinking of having the API route like /api/collection/${collection}/search?query=${query}
collection as a path param and query as a query param since collection is a resource and query is for searching the collection (based on the first StackOverflow link)

@16BitNarwhal 16BitNarwhal self-assigned this Apr 30, 2024
@lintool
Copy link
Member Author

lintool commented May 14, 2024

First impl here #2486 - @16BitNarwhal do you want to leave this issue open or close it?

@16BitNarwhal
Copy link
Member

I think we can close it

@lintool lintool closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants