Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to read from a global config file #210

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

drose-shopify
Copy link
Contributor

Allows the use of a global config file defined at ~/.solargraph.yml

#197

@drose-shopify
Copy link
Contributor Author

I noticed the linked issue asks for the global config to be in ~/.config/solargraph/config.yml. Is there a preference to where the global config should live?

@castwide
Copy link
Owner

Thanks, @drose-shopify!

Using ~/.solargraph.yml is risky because it could make the language server treat the entire home directory as a single workspace, which is almost certainly not the user's intent. I'd prefer either ~/.config/solargraph/config.yml (common convention) or ~/.solargraph/config.yml (reuse of existing data directory). Maybe it could also be configurable with an environment variable, like #125 did with the document cache.

@drose-shopify
Copy link
Contributor Author

drose-shopify commented Jul 17, 2019

Ahhh fair enough, I didn't think about that. Also <3 the idea of using an environment variable to set the path.

@castwide
Copy link
Owner

Awesome, thanks again! Merging to include in version 0.35.

@castwide castwide merged commit badfcea into castwide:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants