Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete waterfalls generated for custom error pages e.g. 404 #1275

Closed
andydavies opened this issue Jun 11, 2019 · 2 comments
Closed

Incomplete waterfalls generated for custom error pages e.g. 404 #1275

andydavies opened this issue Jun 11, 2019 · 2 comments

Comments

@andydavies
Copy link
Contributor

Sites frequently serve custom error pages e.g. https://www.bluefountainmedia.com/asd but WPT generates an incomplete waterfall for them e.g. http://webpagetest.org/result/190611_76_de3d66d1180ed32a753a1872c869ca31/

The traces contain the network requests, and for some sites the screenshots are more complete than others.

Guessing the HTTP Status code short-circuits the response processing somewhere

@nilskuhn
Copy link
Contributor

Congratulation, I never had a customer with the budget to performance optimize an error page ;)
Well, if I think about it again, I had one load testing and scaling it...

@Nooshu
Copy link

Nooshu commented Jun 1, 2020

There is now a workaround for this issue, as Pat has added a fix for the 'Minimum test duration' with 404 pages.

Screenshot 2020-06-01 at 22 42 19

Results in:
waterfall

Updating for reference. Minimum test duration has now been exposed to WPT scripting, so it is now possible to achieve the same results using:

setMinimumStepSeconds 2
navigate https://www.example.com/this-is-a-404-page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants