Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color differentiation to types in object paths #214

Closed
brady-sewall opened this issue Nov 23, 2023 · 1 comment · Fixed by #449
Closed

Add color differentiation to types in object paths #214

brady-sewall opened this issue Nov 23, 2023 · 1 comment · Fixed by #449
Labels
enhancement New feature or request

Comments

@brady-sewall
Copy link

(Sorry for the poor title - I'm not sure what to call this)

Syntax: Liquid

When objects are called in Shopify it starts with the type of object - product, variant, etc. In the screenshots below, variant in variant.metafields.acf_variant.disclaimer_message, specifically.

Other themes I've used (including the stock VS Code themes) highlight that object, which makes it much easier to see what type of object is being referenced.

Other themes:
image

Catppuccin:
image

@sgoudham sgoudham changed the title [REQUEST] Adding color differentiation to types in object paths Add color differentiation to types in object paths Aug 2, 2024
@sgoudham sgoudham added the enhancement New feature or request label Aug 2, 2024
@sgoudham
Copy link
Contributor

sgoudham commented Nov 8, 2024

Hey 👋,
Apologies for the wait!

There seems to be some cross cutting concerns here where the textmate grammar highlights user defined variables and shopify builtin objects the same colour. As a result, I wasn't comfortable using red which is our builtin colour.

While it might not make the most sense, I've went with pink to follow the idea of Custom Components in React. See the screenshot shown below:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants