Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] ExtraDimensionsPackage in Example is not required anymore #52

Closed
Maxwell2022 opened this issue Jan 13, 2017 · 3 comments
Closed

[Android] ExtraDimensionsPackage in Example is not required anymore #52

Maxwell2022 opened this issue Jan 13, 2017 · 3 comments
Assignees
@bradbyte
Labels
Android
Milestone
1.0 - Programmabl...

Comments

@Maxwell2022
Copy link

In the Android example you are using: react-native-extra-dimensions-android

It looks like the issue with android phone dimensions has been fixed in react native 0.21.0

facebook/react-native#4934
facebook/react-native#5762
@bradbyte
Copy link
Contributor

@Maxwell2022 Thanks! I need to redo the example anyway with the latest versions of React + Gifted Chat.

@bradbyte
Copy link
Contributor

If you wanted to take a shot at the change feel free to fork programable-chat (yes, I know it's misspelled).

@bradbyte bradbyte added this to the 1.0 - Programmable Chat milestone Jan 13, 2017
@bradbyte bradbyte self-assigned this Jan 13, 2017
@bradbyte bradbyte mentioned this issue Mar 7, 2017
Closed
@bradbyte
Copy link
Contributor

bradbyte commented Mar 7, 2017

Moved to ccm-innovation/react-native-twilio-chat#3.

@bradbyte bradbyte closed this as completed Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradbyte bradbyte

Labels
Android
Projects
None yet
Milestone
1.0 - Programmable Chat
Development

No branches or pull requests
2 participants
@Maxwell2022 @bradbyte