Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s Quantity type in python does not have __eq__ method #1152

Open
crazed opened this issue Jan 26, 2023 · 0 comments
Open

K8s Quantity type in python does not have __eq__ method #1152

crazed opened this issue Jan 26, 2023 · 0 comments
Labels
bug Something isn't working effort/small 1 day tops good-first-issue Good for newcomers priority/p1 Should be on near term plans

Comments

@crazed
Copy link

crazed commented Jan 26, 2023

Description of the bug:

It is currently impossible to quickly assert if two k8s.Quantity objects are equal without using the .value property on the resulting object.

Reproduction Steps:

In [3]: one = k8s.Quantity.from_string('foo')

In [4]: two = k8s.Quantity.from_string('foo')

In [5]: one == two
Out[5]: False

Error Log:

No errors, just that there is no __eq__ method

Environment:

  • Framework Version: 2.5.59
  • OS: Linux 5.10.76-linuxkit reorganize as a mono-repo #1 SMP PREEMPT Mon Nov 8 11:22:26 UTC 2021 aarch64 aarch64 aarch64 GNU/Linux

Other:

The generated k8s.Quantity type could add an __eq__ method that looks at the .value property


This is 🐛 Bug Report

@crazed crazed added bug Something isn't working needs-triage Priority and effort undetermined yet labels Jan 26, 2023
@vinayak-kukreja vinayak-kukreja added good-first-issue Good for newcomers effort/small 1 day tops priority/p1 Should be on near term plans and removed needs-triage Priority and effort undetermined yet labels Aug 14, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/small 1 day tops good-first-issue Good for newcomers priority/p1 Should be on near term plans
Projects
None yet
Development

No branches or pull requests

2 participants