feat: add tag prop to gcds-sr-only component #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanWallace
requested changes
Mar 26, 2024
| @@ -64,7 +64,7 @@ export class GcdsHeader { | |||
| return <slot name="skip-to-nav"></slot>; | |||
| } else if (this.skipToHref) { | |||
| return ( | |||
| <nav class="gcds-header__skip-to-nav"> | |||
| <nav class="gcds-header__skip-to-nav" aria-label={i18n[this.lang].skip}> | |||
There was a problem hiding this comment.
We originally had this nav landmarked labelled this, but chose to remove the label when one of our a11y tests became confused on the repeated "Skip to main content" read out.
There was a problem hiding this comment.
Oh, you are right, I forgot about that. Got too into the landmark label zone :D Good flag!
daine
reviewed
Mar 26, 2024
Comment on lines
39
to
49
| it('renders heading tag', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [GcdsSrOnly], | ||
| html: `<gcds-sr-only tag="h2">Hidden text</gcds-sr-only>`, | ||
| }); | ||
| expect(page.root).toEqualHtml(` | ||
| <gcds-sr-only tag="h2"> | ||
| <mock:shadow-root> | ||
| <h2> | ||
| <slot></slot> | ||
| </h2> |
There was a problem hiding this comment.
Would be nice if we have tests for the different tag types as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Added
tagprop togcds-sr-onlyto allow users to hide heading content as well as regular text content.Integrated into the following, existing components:
Dev board ticket