fix: Update utility functions for more usability #495
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Update the
assignLanguage
andinheritAttributes
to be more usable and functional with GC Design System components going forward.assignLanguage changes
Previously the
assignLanguage
would check if alang
attribute has been assigned to the host element of a component if needed. If not found, the function would then check the document element to get the page language for the component.To better match how
lang
works in HTML, the component will now check it's ancestors all the way up to the document element for alang
attribute. This allows developers to tag sections of a page a different language from the default page language and have the component inherit the correct language.inheritAttributes changes
inheritAttributes
was built to take data attributes assigned to form components and pass them down to the input rendered in each form component and remove the attribute from the host element. With the introduction of form-associated components and shadow-dom, data attributes will no longer be passed down to the rendered input since the component is now recognized as a form input in HTML forms.