Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update stepper tokens to match new design #278

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ethanWallace
Copy link
Collaborator

@ethanWallace ethanWallace commented Jun 26, 2024

Summary | Résumé

Update component tokens for gcds-stepper to match new design in Figma.

Will need to be merged before cds-snc/gcds-components#573

melaniebmn
melaniebmn previously approved these changes Jun 26, 2024
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace changed the title refactor: Update stepper tokens to match V2 design refactor: Update stepper tokens to match new design Jun 26, 2024
daine
daine previously approved these changes Jun 26, 2024
@ethanWallace ethanWallace dismissed stale reviews from daine and melaniebmn via 8b9bba0 June 26, 2024 19:08
@ethanWallace
Copy link
Collaborator Author

@daine @melaniebmn Sorry was just alerted of a design update to the spacing between the steps and heading text.

@ethanWallace ethanWallace requested review from daine and melaniebmn June 26, 2024 19:09
Copy link
Collaborator

@melaniebmn melaniebmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ethanWallace ethanWallace merged commit f2abfb8 into main Jun 27, 2024
1 check passed
@ethanWallace ethanWallace deleted the refactor/stepper-component-tokens branch June 27, 2024 19:58
melaniebmn added a commit that referenced this pull request Jul 24, 2024
melaniebmn added a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants