Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurlClient isn't used anymore and probably could be deleted #1537

Closed
dobosevych opened this issue Apr 19, 2022 · 9 comments
Closed

CurlClient isn't used anymore and probably could be deleted #1537

dobosevych opened this issue Apr 19, 2022 · 9 comments
Labels
Component: Amazon SQS Broker dependencies Pull requests that update a dependency file

Comments

@dobosevych
Copy link
Contributor

dobosevych commented Apr 19, 2022

CurlClient isn't used anymore and it is broken for a lot of time, so probably can be removedhttp/curl.py. There are several reasons for that

  1. It depends on pycurl that isn't in any dependencies, so on next code we will receive an error
from kombu.asynchronous.http.curl import CurlClient
c = CurlClient()
  1. I don't see any usage client CurlClient or Client in celery repo

In any case code could be at least cleaned

@open-collective-bot
Copy link

Hey @dobosevych 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

@auvipy
Copy link
Member

auvipy commented Apr 19, 2022

it was scheduled to removed

@auvipy
Copy link
Member

auvipy commented Apr 19, 2022

pycurl might have usage in kombu most probably

@dobosevych
Copy link
Contributor Author

but it isn't in any dependencies already
should I help with code cleaning?

@auvipy
Copy link
Member

auvipy commented Apr 19, 2022

boto sqs?

@dobosevych
Copy link
Contributor Author

pip install kombu
>>> from kombu.asynchronous.http.curl import CurlClient
>>> c = CurlClient()

will lead to an error. This I suppose should be fixed or cleaned. What is your suggestion?

@auvipy
Copy link
Member

auvipy commented Apr 23, 2022

#737 check this please

@shadowrider17
Copy link

Why does kombu needs pycurl but doesn't specify this in requirements? Can someone please help with this. Thank you.

@spawn-guy
Copy link
Contributor

check this out, please. #2134 and see if it works for your needs (planned to be in v5.5)

@auvipy auvipy closed this as completed Oct 14, 2024
@auvipy auvipy added Component: Amazon SQS Broker dependencies Pull requests that update a dependency file labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Amazon SQS Broker dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

4 participants