Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fraud: Bad encoding fraud proofs for unordered share #1742

Closed
rootulp opened this issue Feb 13, 2023 · 0 comments
Closed

fraud: Bad encoding fraud proofs for unordered share #1742

rootulp opened this issue Feb 13, 2023 · 0 comments

Comments

@rootulp
Copy link
Contributor

rootulp commented Feb 13, 2023

Context

While reviewing the NMT, @evan-forbes raised the following scenario:

A malicious 2/3 majority of consensus nodes confirm a block that has a data square with one share that isn't lexicographically ordered. It is possible for light nodes to miss sampling the one unordered share. Since light nodes don't reconstruct the entire data square, they need to be made aware of such behavior (presumably via a bad encoding fraud proof).

Problem

It isn't clear that the current implementation of bad encoding fraud proofs work for this scenario.

Proposal

  1. Update NMT to handle this scenario. See Defining and Clarifying the Verification Process for NMT Proofs Generated from Non-Lexicographically Ordered Trees nmt#97
  2. Investigate the changes needed (likely in this repo) to support a bad encoding fraud proof for a data square with one unordered share
  3. Improve unit test coverage to account for this scenario (related: eds/byzantine: Bad encoding fraud proofs need more unit testing #1086)
@celestiaorg celestiaorg locked and limited conversation to collaborators Jan 9, 2024
@ramin ramin converted this issue into discussion #3079 Jan 9, 2024
@github-project-automation github-project-automation bot moved this from TODO to Done in Celestia Node Jan 9, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant