Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote usage of EventBus instead of Events; remove custom Events API #7

Closed
2 tasks
Wondertan opened this issue Oct 25, 2021 · 0 comments · Fixed by #8
Closed
2 tasks

Promote usage of EventBus instead of Events; remove custom Events API #7

Wondertan opened this issue Oct 25, 2021 · 0 comments · Fixed by #8

Comments

@Wondertan
Copy link
Member

Background

Now that libp2p/go-libp2p#1230 exists, it does not make sense to define custom events API, and users should rely on EventBus instead.

Actions

  • Remove Events method
  • Write a test asserting a random msg being successfully sent after EvtPeerConnectednessChanged is recvd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Work towards reliability celestiaorg/go-libp2p-messenger
1 participant
@Wondertan