Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring all pkgs to receive a logger object instead of default logrus #396

Closed
mojtaba-esk opened this issue May 29, 2024 · 0 comments · Fixed by #445
Closed

Consider refactoring all pkgs to receive a logger object instead of default logrus #396

mojtaba-esk opened this issue May 29, 2024 · 0 comments · Fixed by #445
Assignees
@mojtaba-esk
Labels
knuu
Milestone
v0.15.0

Comments

@mojtaba-esk
Copy link
Contributor

Receiving a logger object from user makes our packages more composable. Right now only knuu pkg does this, this issue suggest to propagate it throughout the entire repo.
@github-actions github-actions bot added the knuu label May 29, 2024
@mojtaba-esk mojtaba-esk self-assigned this Jun 10, 2024
@mojtaba-esk mojtaba-esk moved this to In Progress in Celestia DevOps/Testing Jun 10, 2024
@mojtaba-esk mojtaba-esk mentioned this issue Jun 19, 2024
Merged
@mojtaba-esk mojtaba-esk moved this from In Progress to Needs Review in Celestia DevOps/Testing Jun 19, 2024
@mojtaba-esk mojtaba-esk added this to the v0.15.0 milestone Jun 26, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Celestia DevOps/Testing Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojtaba-esk mojtaba-esk

Labels
knuu
Projects
Celestia DevOps/Testing
Archived in project
Milestone
v0.15.0
Development

Successfully merging a pull request may close this issue.

chore: refactor to use logger obj instead celestiaorg/knuu
1 participant
@mojtaba-esk