Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CloneWithSuffix does not check for Instance state #531

Closed
Tracked by #487
smuu opened this issue Jul 26, 2024 · 3 comments · Fixed by #570
Closed
Tracked by #487

feat: CloneWithSuffix does not check for Instance state #531

smuu opened this issue Jul 26, 2024 · 3 comments · Fixed by #570
Assignees
Labels
bug Something isn't working knuu

Comments

@smuu
Copy link
Member

smuu commented Jul 26, 2024

Clone checks for state Instance is in but CloneWithSuffix does not.

func (i *Instance) Clone() (*Instance, error) {

func (i *Instance) CloneWithSuffix(suffix string) *Instance {

@smuu smuu added bug Something isn't working knuu labels Jul 26, 2024
@smuu smuu added this to the v0.16.0 milestone Aug 5, 2024
@mojtaba-esk
Copy link
Contributor

This might be fixed by #530

@tty47
Copy link
Contributor

tty47 commented Oct 14, 2024

I think this is already done in the PR merged, right?

@mojtaba-esk
Copy link
Contributor

I think this is already done in the PR merged, right?

Thanks for pointing it out. I am merging #570 as it has two approvals. So then we cal close it

@github-project-automation github-project-automation bot moved this from Needs Review to Done in Celestia DevOps/Testing Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working knuu
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants