Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computing leaf hashes should be done after the range check #139

Closed
andrijamitrovic23 opened this issue Mar 17, 2023 · 3 comments
Closed
Assignees
Labels
audit Issue uncovered during Informal audit enhancement New feature or request

Comments

@andrijamitrovic23
Copy link
Collaborator

computeLeafHashesIfNecessary should be done after the range check. This calculation could be time/resource consuming but unnecessarily called if the range is invalid.

@andrijamitrovic23
Copy link
Collaborator Author

andrijamitrovic23 commented Mar 17, 2023

@andrijamitrovic23 andrijamitrovic23 added the enhancement New feature or request label Mar 22, 2023
@staheri14
Copy link
Collaborator

staheri14 commented Mar 22, 2023

A relevant issue #108

@rootulp rootulp self-assigned this Mar 22, 2023
@staheri14
Copy link
Collaborator

Thanks for opening the issue, your point is right about the computation overhead, however, in this case, the computeLeafHashesIfNecessary should not be moved as it affects the length of the leafHashes which is used in earlier lines.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Mar 23, 2023
@liamsi liamsi added the audit Issue uncovered during Informal audit label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit Issue uncovered during Informal audit enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants