Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Upstream to 1.9.22 #1179

Closed
mcortesi opened this issue Oct 16, 2020 · 2 comments
Closed

Merge Upstream to 1.9.22 #1179

mcortesi opened this issue Oct 16, 2020 · 2 comments
Assignees
@oneeman
Milestone
Milestone 8

Comments

@mcortesi
Copy link
Contributor

Bring upstream changes up to 1.9.22
@mcortesi mcortesi added this to the Milestone 7 milestone Oct 16, 2020
@mcortesi mcortesi added the epic label Oct 16, 2020
@oneeman oneeman mentioned this issue Oct 16, 2020
Closed
@oneeman
Copy link
Contributor

oneeman commented Oct 16, 2020

A few things to check off when doing this (this list is not exhaustive):

  1. When p2p: new dial scheduler ethereum/go-ethereum#20592 is merged, it should fix Validators/proxies initiate new dyndial connections even when they're at the max peer limit #1180, so that issue can be closed then.
  2. When p2p: remove MeteredPeerEvent ethereum/go-ethereum#20679 is merged, then p2p.Server connections not being tracked properly #1172 will no longer be a thing since the PR removes that metric and the associated code, so that issue can be closed then.
  3. The new dialer (p2p: new dial scheduler ethereum/go-ethereum#20592) includes a breaking change in what addStatic() does. Prior to this, if you call addStatic for a node that's already in static, but with a different address, it gets updated: https://github.com/ethereum/go-ethereum/blob/4ea9b62b5ce396c5609c100b8b2c05f11d1d7fac/p2p/dial.go#L111 . After this, it does not get updated: https://github.com/ethereum/go-ethereum/blob/90caa2cabbd46c3e712eb7216bd668dd02bb15a8/p2p/dial.go#L276-L282 . I'm not sure whether we are relying on the current behavior anywhere, so it's something to check and remedy if necessary.

@mcortesi mcortesi modified the milestones: Milestone 7, Milestone 8 Dec 3, 2020
@mcortesi
Copy link
Contributor Author

Closing this now. We'll use individual issues for now on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oneeman oneeman

Labels
None yet
Projects
None yet
Milestone
Milestone 8
Development

No branches or pull requests
2 participants
@mcortesi @oneeman