Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lockout on PIN attempts if there are several incorrect attempts #782

Closed
nityas opened this issue Feb 5, 2020 · 1 comment
Closed

Implement lockout on PIN attempts if there are several incorrect attempts #782

nityas opened this issue Feb 5, 2020 · 1 comment
Assignees
@Pedro-vk
Labels
stale An issue that might be irrelevant wallet

Comments

@nityas
Copy link
Contributor

nityas commented Feb 5, 2020

Expected Behavior

see discussion here: celo-org/celo-monorepo#2574 (comment)

Custom pin screen is currently vulnerable to brute forcing as we implement no lockout, explore options for this.

Current Behavior

PIN can be attempted without penalty until correct
@nityas nityas changed the title Implement smarter lockout on PIN attempts if there are several incorrect attempts Implement lockout on PIN attempts if there are several incorrect attempts Feb 5, 2020
@Pedro-vk
Copy link
Contributor

Pedro-vk commented Jul 2, 2021

@jeanregisser @nityas there is no description of what to show when the user fails, how many tries, and what to do if the user fails all the times
I'll start investigating how to lock the app if the user fails, but I'll need the rest of the information to finish the task

@MuckT MuckT transferred this issue from celo-org/celo-monorepo Jul 6, 2021
@MuckT MuckT added the wallet label Jul 7, 2021
@silasbw silasbw added the stale An issue that might be irrelevant label Oct 30, 2021
@silasbw silasbw closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pedro-vk Pedro-vk

Labels
stale An issue that might be irrelevant wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Pedro-vk @silasbw @nityas @MuckT