Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Valora] Investigate Methods for identifying for Merchant Payments and Mirror Refunds in Valora Feed #8842

Closed
aslawson opened this issue Oct 25, 2021 · 1 comment
Closed

[Valora] Investigate Methods for identifying for Merchant Payments and Mirror Refunds in Valora Feed #8842

aslawson opened this issue Oct 25, 2021 · 1 comment
Labels
Applications Applications circle tasks mobile payments Celo Payments Protocol Priority: P2 Major stale

Comments

@aslawson
Copy link
Contributor

aslawson commented Oct 25, 2021 •
edited
Loading

Need to figure out how to identify merchant payments and refunds so we can indicate them in the transaction feed. Mirror transactions are auto-refunds from the FirstDAG address.

  • Amount will vary because gasfees deducted from refund, so cannot use exact fund amount for matching

1 Idea:
Valora currently has TokenTransactionType to indicate various transaction types. Can we leverage this to store and indicate merchant transaction in the feed?

  • Longer term offchain storage or other mechanism to for First to send transaction with referenceID
@aslawson aslawson added Applications Applications circle tasks mobile payments Celo Payments Protocol labels Oct 25, 2021
This was referenced Oct 27, 2021
Open
Open
Open
Open
Open
This was referenced Nov 3, 2021
Open
Open
Open
Open
Open
Open
This was referenced Nov 13, 2021
Open
Open
Open
Open
Open
Open
This was referenced Nov 22, 2021
Open
Open
@aslawson aslawson added the Priority: P2 Major label Nov 29, 2021
@aslawson aslawson changed the title [Valora] Investigate TokenTransactionType for Merchant Payments and Mirror Refunds [Valora] Investigate Methods for identifying for Merchant Payments and Mirror Refunds in Valora Feed Nov 29, 2021
@aslawson aslawson mentioned this issue Nov 29, 2021
Closed
2 tasks
This was referenced Nov 30, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 8, 2021
Open
This was referenced Dec 16, 2021
Open
Open
This was referenced Apr 22, 2022
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue May 1, 2022
Open
This was referenced May 26, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Jun 5, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 26, 2022
Open
@leojoy95 leojoy95 mentioned this issue Jun 27, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jun 27, 2022
Open
This was referenced Aug 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 8, 2022
Open
This was referenced Oct 6, 2022
Open
Open
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2023

This issue is stale and will be closed in 30 days without activity

@github-actions github-actions bot added the stale label Feb 4, 2023
@github-actions github-actions bot closed this as completed Mar 7, 2023
This was referenced Apr 24, 2023
Open
Open
Open
This was referenced Jun 23, 2023
Open
Open
Open
Open
@lili2311 lili2311 mentioned this issue Jun 24, 2023
Open
@lili2311 lili2311 mentioned this issue Dec 10, 2023
Open
This was referenced May 22, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Applications Applications circle tasks mobile payments Celo Payments Protocol Priority: P2 Major stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aslawson