Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Developers SBAT check contract code existence in Governance contract #911

Closed
asaj opened this issue Sep 11, 2019 · 1 comment
Closed

Developers SBAT check contract code existence in Governance contract #911

asaj opened this issue Sep 11, 2019 · 1 comment
Assignees
@aaitor
Labels
good first issue Good for newcomers protocol All issues relating to protocol packages

Comments

@asaj
Copy link
Contributor

asaj commented Sep 11, 2019

Expected Behavior

Use EXTCODESIZE to check contract existence before call in Governance.sol

Current Behavior

No check
@asaj asaj added protocol All issues relating to protocol packages good first issue Good for newcomers labels Sep 11, 2019
@aaitor aaitor self-assigned this Sep 15, 2019
@r00ted199 r00ted199 mentioned this issue Sep 20, 2019
Merged
@aaitor aaitor mentioned this issue Oct 1, 2019
Merged
@aaitor aaitor assigned mrsmkl and unassigned mrsmkl Oct 9, 2019
@aaitor aaitor mentioned this issue Oct 10, 2019
Merged
@diminator
Copy link
Contributor

solved by #1289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaitor aaitor

Labels
good first issue Good for newcomers protocol All issues relating to protocol packages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrsmkl @aaitor @asaj @diminator