Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a loaded controller profile under a different name does not update the name correctly #501

Closed
jn64 opened this issue Nov 17, 2022 · 1 comment · Fixed by #1217
Closed

Comments

@jn64
Copy link
Contributor

jn64 commented Nov 17, 2022

Cemu version: latest b1c7058 + 9afae50 from #500
OS: Fedora 36

Description

When saving a loaded controller profile under a different name, the new name is used for the filename but is not updated in the <profile> tag.

Note: This is dependent on PR #500 but I think the bug exists before, it's just exposed to me now that I can load profiles.

After further testing, it doesn't need #500, can be reproduced from main branch.

Steps to reproduce

  1. Create a profile with name foo
  2. Save profile → controllerProfiles/foo.xml is created containing <profile>foo</profile>
  3. With profile foo loaded, change the name to bar
  4. Save profile → controllerProfiles/bar.xml is created, still containing <profile>foo</profile>

Suspected cause

if (emulated_controller->has_profile_name())
emulated_controller_node.append_child("profile").append_child(pugi::node_pcdata).set_value(
emulated_controller->get_profile_name().c_str());

When saving, it's getting the existing profile name to write to the <profile> tag?

@BParks21
Copy link

Yeah I experience this all the time It's annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants