Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database keys API #313

Closed
kgodey opened this issue Jun 30, 2021 · 7 comments · Fixed by #580
Closed

Remove database keys API #313

kgodey opened this issue Jun 30, 2021 · 7 comments · Fixed by #580
Assignees
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: backend Related to Python, Django, and simple SQL

Comments

@kgodey
Copy link
Contributor

kgodey commented Jun 30, 2021

Problem

The database keys API is deprecated, we don't need it around.

Proposed solution

Delete code associated with it once the frontend switches away from using it.

Additional context

@kgodey kgodey added type: enhancement work: backend Related to Python, Django, and simple SQL needs: unblocking Blocked by other work labels Jun 30, 2021
@kgodey kgodey added this to the 05. Multiple Database Support milestone Jun 30, 2021
@kgodey kgodey added ready Ready for implementation good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this and removed needs: unblocking Blocked by other work labels Aug 9, 2021
@kgodey kgodey modified the milestones: 10. Multiple Database Support, 2021-08 improvements Aug 9, 2021
@arvind-1
Copy link
Contributor

@kgodey Thanks. I will start work on this one then. I will start setting up my code.

@kgodey
Copy link
Contributor Author

kgodey commented Aug 17, 2021

Thanks @arvind-1! Please feel free to join us on Matrix and ask questions either there or on the issue.

@arvind-1
Copy link
Contributor

@kgodey i am facing following error while trying run app. Could you help me on this?

db_1   | 2021-08-18 10:10:37.073 UTC [86] STATEMENT:  SELECT "mathesar_database"."id", "mathesar_database"."created_at", "mathesar_database"."updated_at", "mathesar_database"."name", "mathesar_database"."deleted" FROM "mathesar_database" WHERE "mathesar_database"."name" = 'favicon.ico' LIMIT 21
web_1  | Internal Server Error: /favicon.ico/
web_1  | Traceback (most recent call last):
web_1  |   File "/usr/local/lib/python3.9/site-packages/django/db/backends/utils.py", line 84, in _execute
web_1  |     return self.cursor.execute(sql, params)
web_1  | psycopg2.errors.UndefinedTable: relation "mathesar_database" does not exist
web_1  | LINE 1: ...abase"."name", "mathesar_database"."deleted" FROM "mathesar_... 

@kgodey
Copy link
Contributor Author

kgodey commented Aug 18, 2021

@arvind-1 Did you run all the local development steps in the README: https://github.com/centerofci/mathesar#local-development? It looks like you may not have run the migrate step.

@arvind-1
Copy link
Contributor

@kgodey I haven't run that. I tried right after docker-compose up. Now that i followed other two steps it works alright now. Thanks.

@arvind-1
Copy link
Contributor

@kgodey I went through all the change that have made for this. To be clear here i have to delete file mathesar/database/utils.py
is that correct or am i doing wrong ?

@kgodey
Copy link
Contributor Author

kgodey commented Aug 18, 2021

@arvind-1 That is not correct. You have to delete all the code related to serving the /api/v0/database_keys/ API, which includes the URL, viewset, serializer, and tests. You should also ensure that any functions called in any of those are used in other places in the code, otherwise you should delete those. You can see the API locally at http://localhost:8000/api/v0/database_keys/.

arvind-1 added a commit to arvind-1/mathesar that referenced this issue Aug 18, 2021
kgodey added a commit that referenced this issue Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants