Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test to make sure CLI flags still turn on the statediffing service after a rebase #181

Closed
i-norden opened this issue Dec 27, 2021 · 2 comments
Assignees

Comments

@i-norden
Copy link
Collaborator

i-norden commented Dec 27, 2021

Usually the culprit for a break in the statediffing service configuration is due to changes in cmd/geth/config.go.makeFullNode()

@abdulrabbani00
Copy link

abdulrabbani00 commented Mar 7, 2022

@i-norden - Would you be able to provide more context? This is the assumption that I am making:

  • You want me to put together some sort of GitHub action workflow that will do the following:
    • Be triggered on a "rebase" event.
    • Run geth with a few preconfigured CLI flags.
    • Make sure that the statediffing service is running properly.
  • Please let me know if these assumptions are accurate. If they are, can you help me understand the following?
    • In what context are you using "rebase?"
    • Are there a specified set of CLI flags used that you want me to test with?
    • The following variable should indicate whether statediff has started

Thank you

@abdulrabbani00
Copy link

@i-norden - This seems to be a low lift, just a few questions:

  • When you say rebase, are you referring to fetching from upstream?
  • Should we check for any differences in the cmd/geth/config.go.makeFullNode() function?

I would assume the CI Action would do the following:

  1. Trigger on fetch from upstream.
  2. Buildgeth-linux-amd
  3. Start geth-linux-amd using the --statediff flags.
  4. Ensure that geth runs with a 0 return code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants