Remove PhantomJS dependency

[zramsay]

Running yarn && yarn build with a fresh install from root of repo, on Linux, I get this error:

[4/4] Building fresh packages...
[-/19] ⢀ waiting...
[-/19] ⢀ waiting...
[-/19] ⢀ waiting...
[16/19] ⢀ phantomjs-prebuilt
error /root/watcher-ts/node_modules/phantomjs-prebuilt: Command failed.
Exit code: 1
Command: node install.js
Arguments: 
Directory: /root/watcher-ts/node_modules/phantomjs-prebuilt
Output:
PhantomJS not found on PATH
Downloading https://github.com/Medium/phantomjs/releases/download/v2.1.1/phantomjs-2.1.1-linux-x86_64.tar.bz2
Saving to /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
Receiving...

Received 22866K total.
Extracting tar contents (via spawned process)
Error extracting archive
Phantom installation failed Error: Command failed: tar jxf /tmp/phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
tar (child): bzip2: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

node version: 18.7.0
yarn version: 1.22.19

[zramsay]

duh: Medium/phantomjs#630
solution: install bzip2

[dboreham]

Nononono.....we shouldn't have phantomjs at all.

Here's where it came from:

$ yarn why phantomjs-prebuilt
yarn why v1.22.19
[1/4] Why do we have the module "phantomjs-prebuilt"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "_project_#@cerc-io#react-peer#nwb" depends on it
   - Hoisted from "_project_#@cerc-io#react-peer#nwb#phantomjs-prebuilt"
   - Hoisted from "_project_#@cerc-io#react-peer#nwb#karma-phantomjs-launcher#phantomjs-prebuilt"
info Disk size without dependencies: "65.52MB"
info Disk size with unique dependencies: "67.38MB"
info Disk size with transitive dependencies: "75.13MB"
info Number of shared dependencies: 60
Done in 1.51s.

[dboreham]

It came from here : https://github.com/cerc-io/watcher-ts/blob/main/packages/react-peer/package.json#L27
This package references Phantom. It's a dev dependency. Seems like a bad idea?

[zramsay]

yeah all these new peer packages increased the time to run yarn && yarn build by an order of magnitude

[dboreham]

Seems to be a known issue: insin/nwb#577

[ashwinphatak]

A couple of options to address this:

• Find another tool to replace nwb
• Move the react-peer package into its own repo

[zramsay]

+1 for moving the peer packages to their own repo.